Chai Mocha tests #60

prabalsingh24 · 2020-05-14T20:51:13Z

fixes #58
Added Chai and Mocha Tests

prabalsingh24 · 2020-05-14T20:57:52Z

I changed the config file. Changed the DB to judgeapi-tests. So make sure you create another similar DB in postgres.
I think it would be better to have a test-config.json. and modify the npm test to use that config. Your thoughts?
@jatinkatyal13

jatinkatyal13 · 2020-05-14T21:40:11Z

sounds good ! All the test config will be isolated from the main config. Just make sure to isolate them in the code as well.

prabalsingh24 · 2020-05-15T09:37:32Z

I found some errors in the code. I've marked them as TODO in the tests. Should I go and open the issue or just solve them in this PR only.
I guess it'd be better if you have a look at them first ( I might be wrong :P)

Also out of curiosity, what do you mean by 'Referer' in api whitelist domains. here

And shouldn't it be apiKey.whitelist_domains.indexOf('Referer') !==-1

test/unit/validators/RunValidator.spec.ts

jatinkatyal13 · 2020-05-15T17:45:29Z

test/unit/validators/RunValidator.spec.ts

+        await runValidator.POST(req, res, nextSpy);
+        // TODO
+        expect(nextSpy.calledOnce).to.be.false;
+        // error thrown == " mode" must be one of [sync, callback, poll]


We are relying on Joi errors and as far as this is concerned, we may move to modes being numerical. For e.g. sync = 0, callback = 1

jatinkatyal13 · 2020-05-15T17:48:09Z

Impressive pull request 🚀

The entire purpose of having the tests is to have a code that works in the production environment. We can fix these errors in different PRs, but identifying them with the exhaustive set test is important.

Let's just Review the ToDos in the test and complete the PR

config.js

jatinkatyal13 · 2020-05-15T17:50:42Z

test/e2e/LangsScenario.spec.ts

+    it('should throw 403 error API key is absent in the request', async () => {
+        const res = await chai.request(app).get(`/api/langs`);
+        expect(res.status).to.equal(403);
+        // TODO this should be res.body.err maybe? (consistent with other error)


Status code will define the error and let's stick with body.message

But the base validator is sending body.err base-validator-error

test/e2e/RunScenario.spec.ts

test/e2e/LangsScenario.spec.ts

jatinkatyal13 · 2020-05-15T17:54:39Z

test/e2e/RunScenario.spec.ts

+        }).send(params);
+
+        expect(res.status).to.equal(200);
+        // TODO ? does not throw error.


It should fail with a 400 status code.

I've created an issue for this.

test/unit/validators/RunValidator.spec.ts

prabalsingh24 · 2020-05-15T22:02:23Z

@jatinkatyal13 Have a look at the PR when you're free :)

prabalsingh24 · 2020-05-15T22:07:03Z

EDIT : tldr, I fixed it :)

I need your help with test-config thing.

I am not able to change the process.env.NODE_ENV

I changed npm test to
cross-env NODE_PATH=src node_modules/.bin/mocha --timeout 12000 --exit --require ts-node/register test/unit/validators/*.ts test/e2e/*.ts && cross-env NODE_ENV=test mocha

But the enviroment is not getting changed.

When I did this
cross-env NODE_ENV=test mocha && NODE_PATH=src node_modules/.bin/mocha --timeout 12000 --exit --require ts-node/register test/unit/validators/*.ts test/e2e/*.ts

the process.env.NODE_ENV was getting changed to test but throwing No test files found error

prabalsingh24 · 2020-05-16T07:06:54Z

about 1400 lines of code 😪
I hope I haven't made many mistakes 😅

jatinkatyal13 · 2020-05-16T10:04:11Z

config/config.js

+const developmentConfig = require('./development-config');
+const testConfig = require('./test-config');
+
+if (process.env.NODE_ENV === 'test') {


Directory structure should be as follows

config/index.js

config/development.js

conifg/test.js

config/production.js

All the common configs will be exported from index.js and overridable based on the NODE_ENV.

jatinkatyal13 · 2020-05-16T10:14:44Z

We should run DB.sync once before starting the test. The test DB, in any case, will be discarded and hence we need not truncate it,

prabalsingh24 · 2020-05-16T16:19:49Z

@jatinkatyal13 made the changes. Also I am doing truncateTable to make sure there no interference b/w the tests. Otherwise unexpected things might happen when something which was created in the previous tests is affecting the other tests

jatinkatyal13 · 2020-05-16T16:48:12Z

Generally following is the process of setting up DB

Setup Tables and Sequences
Seed mock data (Read only data common for all tests)
Seed data per test
Run test
Truncate per test data

prabalsingh24 · 2020-05-16T17:37:19Z

Generally following is the process of setting up DB

@jatinkatyal13 I think I am also doing something similar. Waiting for a complete review :)

jatinkatyal13 · 2020-05-17T13:34:30Z

Setup is perfect now!

Let's remove all the TODOs and let the test fail in the case of wrong result. If the lang is incorrect we should get 400 and if the domain is not whitelisted we should get 403

prabalsingh24 · 2020-05-17T17:02:51Z

Yaay. This is probably my biggest PR . :)

This was referenced May 15, 2020

Replace Stdin-->input and Stdout-->output #61

Closed

fix: change stdin-->input and stdout-->output #64

Merged

jatinkatyal13 suggested changes May 15, 2020

View reviewed changes

jatinkatyal13 reviewed May 15, 2020

View reviewed changes

config.js Outdated Show resolved Hide resolved

jatinkatyal13 reviewed May 15, 2020

View reviewed changes

test/e2e/RunScenario.spec.ts Outdated Show resolved Hide resolved

jatinkatyal13 reviewed May 15, 2020

View reviewed changes

test/e2e/LangsScenario.spec.ts Outdated Show resolved Hide resolved

jatinkatyal13 reviewed May 15, 2020

View reviewed changes

test/unit/validators/RunValidator.spec.ts Outdated Show resolved Hide resolved

prabalsingh24 requested a review from jatinkatyal13 May 15, 2020 22:43

prabalsingh24 force-pushed the chai-tests branch from c33dab6 to cbdc63a Compare May 16, 2020 06:49

prabalsingh24 changed the title ~~Chai tests~~ Chai Mocha tests May 16, 2020

jatinkatyal13 reviewed May 16, 2020

View reviewed changes

prabalsingh24 requested a review from jatinkatyal13 May 16, 2020 16:17

prabalsingh24 added 4 commits May 17, 2020 19:54

feat(e2e-tests): add test/utils (helper functions)

89beef0

delete old tests

4ab9da9

feat(e2e tests) : add tests for POST 'api/runs'

15ba4d8

feat(e2e tests): add tests for GET 'api/langs'

4e2d215

prabalsingh24 added 15 commits May 17, 2020 19:54

feat(e2e-tests): add tests for POST 'api/submit'

cb21303

install(chai) : add chai library in package.json

56958c6

install chai-as-promised

29dca6f

feat(unit-tests): add tests for API Validator

2fdf791

fix: use create instead of bulkCreate

cf50282

install sinon: helps in unit tests

e5a3bb0

feat(unit-tests): add tests for RunValidator

4bbb62f

use one @ts-nochek instead of multiple @ts-ignore

3b334c1

fix todos from review

39af3ef

feat(unit-tests): add tests for SubmitValidator

9de14af

config : add config for testing and development

36c2a3b

fix: replace all old config imports with new config file

4e85fab

refactor config dir

c8a79eb

sync db before tests

cc6c3a2

fix all TODOs

5c65914

prabalsingh24 force-pushed the chai-tests branch from 195c1b5 to 5c65914 Compare May 17, 2020 14:33

jatinkatyal13 approved these changes May 17, 2020

View reviewed changes

jatinkatyal13 merged commit e418264 into coding-blocks:master May 17, 2020

Chai Mocha tests #60

Chai Mocha tests #60

Uh oh!

Conversation

prabalsingh24 commented May 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prabalsingh24 commented May 14, 2020

Uh oh!

jatinkatyal13 commented May 14, 2020

Uh oh!

prabalsingh24 commented May 15, 2020

Uh oh!

Uh oh!

jatinkatyal13 May 15, 2020

Choose a reason for hiding this comment

Uh oh!

jatinkatyal13 commented May 15, 2020

Uh oh!

Uh oh!

jatinkatyal13 May 15, 2020

Choose a reason for hiding this comment

Uh oh!

prabalsingh24 May 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jatinkatyal13 May 15, 2020

Choose a reason for hiding this comment

Uh oh!

prabalsingh24 May 15, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

prabalsingh24 commented May 15, 2020

Uh oh!

prabalsingh24 commented May 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prabalsingh24 commented May 16, 2020

Uh oh!

jatinkatyal13 May 16, 2020

Choose a reason for hiding this comment

Uh oh!

jatinkatyal13 commented May 16, 2020

Uh oh!

prabalsingh24 commented May 16, 2020

Uh oh!

jatinkatyal13 commented May 16, 2020

Uh oh!

prabalsingh24 commented May 16, 2020

Uh oh!

jatinkatyal13 commented May 17, 2020

Uh oh!

prabalsingh24 commented May 17, 2020

Uh oh!

Uh oh!

prabalsingh24 commented May 14, 2020 •

edited

Loading

prabalsingh24 commented May 15, 2020 •

edited

Loading