Skip to content

Applying dimensions fix as per issue #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2020
Merged

Applying dimensions fix as per issue #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6116f1a
Applying dimensions fix as per issue
rubicon9 Aug 10, 2020
f3ac7d3
Removing debug!!
rubicon9 Aug 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@ docs/build
.DS_Store
dist/
build/
__pycache__/
venv/
4 changes: 2 additions & 2 deletions flask_sieve/rules_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,9 @@ def validate_dimensions(self, value, params, **kwargs):
if not self.validate_file(value):
return False
try:
image = Image.open(value.filename)
image = Image.open(value)
w, h = image.size
image.close()
value.seek(0)
return ('%dx%d' % (w, h)) == params[0]
except Exception:
return False
Expand Down
4 changes: 2 additions & 2 deletions tests/test_rules_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ class TestRulesProcessor(unittest.TestCase):
def setUp(self):
self.parser = Parser()
self.processor = RulesProcessor()
self.stream = open('tests/files/image.png')
self.stream = open('tests/files/image.png', 'rb')
self.image_file = FileStorage(
stream=self.stream,
filename='tests/files/image.png',
filename='image.png',
content_type='image/png',
name='image'
)
Expand Down