Fix rendervariations for JPEGField when variation size is None #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
==========================================
+ Coverage 95.22% 97.40% +2.18%
==========================================
Files 5 5
Lines 272 270 -2
==========================================
+ Hits 259 263 +4
+ Misses 13 7 -6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug when running
python manage.py rendervariationson a JPEGField when any of the variation sizes are set toNone. Previously, theprocess_variationmethod would update the width or height of the variation based on the first image that it encounters, then all subsequent images would be rendered at that size, rather than the full size requested by the variation.