Skip to content

create variations manually/asynchronously #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

create variations manually/asynchronously #40

wants to merge 3 commits into from

Conversation

anneFly
Copy link

@anneFly anneFly commented Feb 18, 2015

No description provided.

"""
variations = self.field.variations
for key, variation in variations.items():
self.render_and_save_variation(self, variation)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the content argument is missing

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self is the content

@codingjoe
Copy link
Owner

This feature needs some serious testing and documentation.
Also I'd like to have a callback that triggers a jobs to best started to ensure that the file is on the storage and the db transaction is committed.

@anneFly
Copy link
Author

anneFly commented Feb 19, 2015

I added a test and small fixes.
I did not refactor to using a callable, yet since all my tries on this failed somehow. Either you take over on this or we could do it together.

@codingjoe
Copy link
Owner

@anneFly I will do some further work on this and merge eventually

@codingjoe
Copy link
Owner

I did some changed and merged in 7d8d244

@codingjoe codingjoe closed this Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants