Add class attribute to change the graph direction

[peterbaumert]

Solve #33

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.14% 🎉

Comparison is base (8d58695) 97.86% compared to head (7a6de12) 98.01%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
+ Coverage   97.86%   98.01%   +0.14%     
==========================================
  Files          17       17              
  Lines         703      705       +2     
==========================================
+ Hits          688      691       +3     
+ Misses         15       14       -1     

Files Changed	Coverage Δ
joeflow/models.py	98.66% <100.00%> (+<0.01%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codingjoe]

Hi @peterbaumert,

Thank you for your contribution. I always love, when people come up with excellent improvements to my packages.

Regarding your suggestion, I believe being able to adapt the direction is a splendid idea. However, I am hesitant to add settings for everything. I believe in most cases, inheritance is the more Pythonic approach to adapting behavior changes.

Might I suggest making direction a class attribute? As an added bonus, this would allow you to alter directions per individual workflow.

Best!
Joe

[codingjoe]

Maybe also go ahead and add a small test to prevent any regression.

[peterbaumert]

Hi @peterbaumert,

Thank you for your contribution. I always love, when people come up with excellent improvements to my packages.

Regarding your suggestion, I believe being able to adapt the direction is a splendid idea. However, I am hesitant to add settings for everything. I believe in most cases, inheritance is the more Pythonic approach to adapting behavior changes.

Might I suggest making direction a class attribute? As an added bonus, this would allow you to alter directions per individual workflow.

Best!

Joe

Yeah that would have made sense now that you mention it :D

Will look into it those days.

The test part will be something that I need to learn about first. Never did it before 🙄

[peterbaumert]

Hi @codingjoe I added a test, but I am not 100% sure if that is sufficient since it's my first time with tests :D Would be great if you could have a look

[codingjoe]

Wonderful, took the liberty and added a commit. I added documentation and a small improvement to your test. Thanks again, for the contribution!