Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fail warnings #19

Merged
merged 3 commits into from
Jul 11, 2022
Merged

fail warnings #19

merged 3 commits into from
Jul 11, 2022

Conversation

codingjoe
Copy link
Owner

  • Add argument to fail for warnings
  • Fail for warnings in pre-commit to promote incremental changes

@codingjoe
Copy link
Owner Author

codingjoe commented Jul 11, 2022

cc @amureki

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #19 (7282dda) into master (bbcf172) will increase coverage by 0.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   93.57%   93.81%   +0.23%     
==========================================
  Files           1        3       +2     
  Lines         109      194      +85     
==========================================
+ Hits          102      182      +80     
- Misses          7       12       +5     
Impacted Files Coverage Δ
relint.py 93.63% <100.00%> (+0.05%) ⬆️
test_relint.py 96.34% <100.00%> (ø)
setup.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c84f01...7282dda. Read the comment docs.

@codingjoe codingjoe merged commit 98442a9 into master Jul 11, 2022
@codingjoe codingjoe deleted the fail-warnings branch July 11, 2022 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants