Fix for issue 105 -- more robust IP and hostname validation #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New commits
New commits 4-19
…input by the user.
|
Stale pull request message |
|
Why the F^Wheck was this automatically closed? Wondering whether this project is still maintained. |
|
Clearly I wasn't quick enough with my edit to avoid getting auto closed. He did respond to one of my other threads though @drwetter, I think he's busy but getting to them slowly but surely. |
|
Ok but why is the bot enabled if he/she cannot get to it atm? |
|
Is this project still alive? |
|
Doesn't look like it @drwetter. It can always be reopened if the maintainer wants this PR, but I'm not going to worry about it anymore until that happens. |
|
I am the original creator of this tool back in 2014 and turned it over to
another maintainer a few years ago due to time constraints I had. I would
love to see the project keep going but I don't think the current maintainer
has done a good job devoting time to it. It really needs a complete
overhaul and rewrite.
…On Tue, Oct 27, 2020 at 10:44 AM Ben ***@***.***> wrote:
Doesn't look like it @drwetter <https://github.com/drwetter>. It can
always be reopened if the maintainer wants this PR, but I'm not going to
worry about it anymore until that happens.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#107 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAY3TXUZHCQJEEMBE5MNBXLSM3THTANCNFSM4OFF22CA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a regex to look for hostname and IPV4 patterns. If this first check passes, then the
ipaddressmodule from the standard library is used to validate the IP address. If a hostname is detected instead of an IP address, it will try to get the fully qualified domain name. Keeping within the standard library,socket.getfqdnwas used for this step. Let me know if you think the FQDN part might be overkill.I added this for options 1 and 7, which prompt the user for an IP address or domain. I left out the domain part for option 7.
Edit to remove stale tag.