fix a little bug of logic #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Describtion when user select a database to steal, there is a bug if user enter database number equal to the account of database plus one leak test: 1-local 2-VASTTEST 3-admin Select a database to steal: 56 Invalid selection. Select a database to steal: 23 Invalid selection. Select a database to steal: 4 Does this database require credentials (y/n)? 4 is a invalid number, but system accept it
…)" out of the "if" statements, because if don't do this, the code in line number 174 will be not executed if user select the option that require credentials.
lead test:
Exception e is "local variable 'myDBConn' referenced before assignment". It indicates the code in line number 174 will be not executed if user select the option that require credentials.
After modification
Exception e is "command SON([('copydb', 1), ('username', 'youngyangyang04'), ('nonce', u'b9d5887c5f7cc17c'), ('fromdb', u'admin'), ('todb', u'admin_stolen'), ('key', u'dcfd7214988466b2f620809fd27015b4'), ('fromhost', '128.95.1.27')]) failed: unable to login { code: 18, ok: 0.0, errmsg: "auth fails” }"
So the code in line number 174 works
Because variable "myIP" should be set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
operator ''>'' should be replace with ''>=' in 157 line number in nsmmongo.py
Describtion when user select a database to steal, there is a bug if user enter database number equal to the account of database plus one
leak test:
1-local
2-VASTTEST
3-admin
Select a database to steal: 56
Invalid selection.
Select a database to steal: 23
Invalid selection.
Select a database to steal: 4
Does this database require credentials (y/n)?
4 is a invalid number, but system accept it