Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matcher fails when trying to use empty string as a pattern #119

Merged
merged 1 commit into from
Feb 18, 2018
Merged

Matcher fails when trying to use empty string as a pattern #119

merged 1 commit into from
Feb 18, 2018

Conversation

jkobus
Copy link
Contributor

@jkobus jkobus commented Jan 23, 2018

Using value like:

{"name": "123"}

for pattern:

{"name": ""}

results in:

TypeError: Argument 1 passed to Coduo\PHPMatcher\Parser::unexpectedSyntaxError() must be of the type array, null given, called in /home/jacek/workspace/php-matcher/src/Parser.php on line 66

/home/jacek/workspace/php-matcher/src/Parser.php:252
/home/jacek/workspace/php-matcher/src/Parser.php:66
/home/jacek/workspace/php-matcher/src/Parser.php:54
/home/jacek/workspace/php-matcher/src/Parser.php:29
/home/jacek/workspace/php-matcher/src/Matcher/StringMatcher.php:43
/home/jacek/workspace/php-matcher/src/Matcher/ChainMatcher.php:32
/home/jacek/workspace/php-matcher/src/Matcher/ChainMatcher.php:33
/home/jacek/workspace/php-matcher/src/Matcher/ArrayMatcher.php:165
/home/jacek/workspace/php-matcher/src/Matcher/ArrayMatcher.php:88
/home/jacek/workspace/php-matcher/src/Matcher/ArrayMatcher.php:46
/home/jacek/workspace/php-matcher/src/Matcher/ChainMatcher.php:33
/home/jacek/workspace/php-matcher/src/Matcher/JsonMatcher.php:35
/home/jacek/workspace/php-matcher/src/Matcher/ChainMatcher.php:33
/home/jacek/workspace/php-matcher/src/Matcher.php:20
/home/jacek/workspace/php-matcher/tests/MatcherTest.php:448

The problem seems to be in the doctrine's AbstractLexer::scan($input):245 that is unable to detect the empty string, therefore the $this->lexer->lookahead used in Parser:61 is null, and that causes the TypeError: Argument 1 passed to Coduo\PHPMatcher\Parser::unexpectedSyntaxError() must be of the type array, null given when trying to raise the unexpectedSyntaxError (PatternException).

I am not very familiar with doctrine's lexer; I tried to force it to detect the empty string by modifying getCatchablePatterns but with no results - though I think, It might be possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants