Matcher fails when trying to use empty string as a pattern #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using value like:
{"name": "123"}
for pattern:
{"name": ""}
results in:
The problem seems to be in the doctrine's
AbstractLexer::scan($input):245
that is unable to detect the empty string, therefore the$this->lexer->lookahead
used inParser:61
isnull
, and that causes theTypeError: Argument 1 passed to Coduo\PHPMatcher\Parser::unexpectedSyntaxError() must be of the type array, null given
when trying to raise theunexpectedSyntaxError
(PatternException
).I am not very familiar with doctrine's lexer; I tried to force it to detect the empty string by modifying
getCatchablePatterns
but with no results - though I think, It might be possible.