Fixed handling arrays with keys having brackets in array matcher #196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Array matcher is throwing an exception when array has a key with brackets.
See example below:
Value:
Pattern:
The reason for that is because
Symfony\Component\PropertyAccess\Exception\InvalidPropertyPathException
is thrown inSymfony\Component\PropertyAccess\PropertyPath
constructor because such key does not match regex for valid property.This PR attempts to fix it.
I looked into the usage of
PropertyPath
andPropertyAccessor
inArrayMatcher
and it seems that it was needed only to perform simple operation (basically stripping[
and]
from beginning and end of a path string). I simplified the operation by adding a methodgetKeyFromAccessPath
instead of relying onPropertyAccessor
.All tests passed so I assume that it will not break anything else :)
Additionally, it turned out that
symfony/property-access
is not used anywhere else in the project so I removed it from Composer dependencies.