Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics to BigQuery #351

Merged
merged 29 commits into from
May 18, 2023
Merged

Analytics to BigQuery #351

merged 29 commits into from
May 18, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented May 10, 2023

Dependency: cofacts/rumors-db#62

This PR implements the following items recorded in the design doc:

  • Loads rumors-db as submodules so that we can re-use Typwscripts type
  • integrate BigQuery insert
  • replace universal-analytics occurrences with own functions
    • inside these functions we still call ua() so that we send to both BQ and GA in the sake time to verify implementation

@MrOrz MrOrz changed the title Bigquery Analytics to BigQuery May 10, 2023
@coveralls
Copy link

coveralls commented May 15, 2023

Pull Request Test Coverage Report for Build 5017691545

  • 15 of 19 (78.95%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 91.078%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/ga.ts 13 17 76.47%
Totals Coverage Status
Change from base Build 4874811899: -0.5%
Covered Lines: 974
Relevant Lines: 1046

💛 - Coveralls

@MrOrz MrOrz marked this pull request as ready for review May 16, 2023 18:12
@MrOrz MrOrz requested a review from nonumpa May 16, 2023 18:12
@MrOrz MrOrz self-assigned this May 16, 2023
@MrOrz MrOrz merged commit afa6679 into master May 18, 2023
@MrOrz MrOrz deleted the bigquery branch May 18, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants