Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3] remove selectedArticleText and selectedReplyId from context #368

Merged
merged 5 commits into from
Oct 18, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 18, 2023

  • Removed selectedArticleText and selectedReplyId properties from the Context type in chatbotState.ts file.
  • Added a new text property to load selectedArticleText in GetArticle query of the choosingReply.js file.
  • Made changes to a snapshot file.

Copy link
Member Author

MrOrz commented Oct 18, 2023

@coveralls
Copy link

coveralls commented Oct 18, 2023

Pull Request Test Coverage Report for Build 6560721897

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 89.964%

Totals Coverage Status
Change from base Build 6535987939: -0.05%
Covered Lines: 1000
Relevant Lines: 1075

💛 - Coveralls

@MrOrz MrOrz marked this pull request as ready for review October 18, 2023 04:30
@MrOrz MrOrz requested review from nonumpa and bil4444 October 18, 2023 04:30
@MrOrz MrOrz self-assigned this Oct 18, 2023
@MrOrz MrOrz temporarily deployed to staging October 18, 2023 04:36 — with GitHub Actions Inactive
@MrOrz MrOrz temporarily deployed to staging October 18, 2023 12:22 — with GitHub Actions Inactive
Copy link
Member Author

MrOrz commented Oct 18, 2023

Merge activity

  • Oct 18, 2:04 PM: @MrOrz started a stack merge that includes this pull request via Graphite.
  • Oct 18, 2:04 PM: @MrOrz merged this pull request with Graphite.

Base automatically changed from ts to master October 18, 2023 18:04
@MrOrz MrOrz merged commit d062abb into master Oct 18, 2023
7 of 9 checks passed
@MrOrz MrOrz deleted the remove-selected-in-context branch October 18, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants