Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image and handle error in URL previews #141

Merged
merged 2 commits into from
Oct 16, 2018
Merged

Add image and handle error in URL previews #141

merged 2 commits into from
Oct 16, 2018

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 10, 2018

Note: this PR depends on API change cofacts/rumors-api#106

Related to #102 .

Screenshot

2018-10-10 8 15 47

@MrOrz MrOrz self-assigned this Oct 10, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.781% when pulling f61bc91 on url-preview-img into 7c62574 on url-preview.

@MrOrz MrOrz requested review from darkbtf and nonumpa October 10, 2018 14:25
@MrOrz MrOrz changed the base branch from url-preview to master October 16, 2018 05:49
@MrOrz MrOrz merged commit a71708c into master Oct 16, 2018
@MrOrz MrOrz deleted the url-preview-img branch October 16, 2018 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants