fix: #417 landing page avatar displaying bug #438
Merged
+22
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrOrz
approved these changes
Jul 4, 2021
There was a problem hiding this comment.
Thanks a lot for finding the missing data!
I think it would be great if we can do the following to achieve fragment colocation:
- move
USER_QUERYanduseQueryto withinLandingPage/Header, as its data is only used there - use
Avatar.fragment.AvatarDatain query so that we don't need to enumerate all fields that is used byAvatarcomponent
@ulayab are you interested in changing the code above? I can do it after merge as well.
|
Sure! I'll try to deal with it. |
|
Hi @MrOrz I just update the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.