Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements terms page directly under Cofacts website #512

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Implements terms page directly under Cofacts website #512

merged 3 commits into from
Oct 26, 2022

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 25, 2022

  • Loads latest term from Github; updating term do not require a rebuild and redeploy.
  • Loads markdown parser and DOM sanitizer from CDN (so that it does not take space).
  • Includes a link to Github for users to check the revision of this agreement

Desktop

localhost_3000_terms

Mobile

localhost_3000_terms(Pixel 5) (1)

- Loads latest term from Github; updating term do not require a rebuild and redeploy.
- Loads markdown parser and DOM sanitizer from CDN (so that it does not take space).
@MrOrz MrOrz requested review from nonumpa and bil4444 October 25, 2022 16:54
@MrOrz MrOrz self-assigned this Oct 25, 2022
@MrOrz MrOrz marked this pull request as ready for review October 25, 2022 16:55
@coveralls
Copy link

coveralls commented Oct 25, 2022

Coverage Status

Coverage decreased (-0.01%) to 76.235% when pulling f5482f2 on terms into f200783 on master.

@MrOrz MrOrz merged commit 36cfbb3 into master Oct 26, 2022
@MrOrz MrOrz deleted the terms branch October 26, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants