Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust AppFooter #528

Merged
merged 1 commit into from
Feb 13, 2023
Merged

adjust AppFooter #528

merged 1 commit into from
Feb 13, 2023

Conversation

marcussfu
Copy link
Contributor

@marcussfu marcussfu commented Feb 11, 2023 •
edited
Loading

截圖 2023-02-11 下午10 33 15

@coveralls
Copy link

Coverage Status

Coverage: 76.412%. Remained the same when pulling ff580ef on adjustAppFooter into 97f01b6 on master.

@MrOrz MrOrz self-requested a review February 13, 2023 18:28
@MrOrz MrOrz linked an issue Feb 13, 2023 that may be closed by this pull request
Add links to website footer #520
Closed
MrOrz
MrOrz approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@MrOrz MrOrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for reusing the const defined in constants/urls!

@MrOrz MrOrz merged commit e202593 into master Feb 13, 2023
@MrOrz MrOrz deleted the adjustAppFooter branch March 7, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrOrz MrOrz MrOrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add links to website footer
3 participants
@marcussfu @coveralls @MrOrz