-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new options to Article Filters #534
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot missing any filter case
bil4444
approved these changes
Mar 18, 2023
andyy0216
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of #521 and meets requirements in 小聚檢討.
Adds the following filters for article, reply and search page:
Other refactors
ListArticleFilter
object construction intoArticleStatusFilter
ListArticleFilter
and is repeated for article, reply & search article listfilterMap
toArticleStatusFilter
so that users can adjust options to show / hideListPageControls
to Typescripttsconfig.json
so that Typescript recognizes imports from project rootScreenshots
Deployed to staging: https://dev.cofacts.tw/articles
Article list
Reply list
Doesn't have "no replies yet"
Search articles
Search replies
Not affected