Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new options to Article Filters #534

Merged
merged 16 commits into from
Mar 18, 2023
Merged

Add new options to Article Filters #534

merged 16 commits into from
Mar 18, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Mar 16, 2023

Fixes some of #521 and meets requirements in 小聚檢討.

Adds the following filters for article, reply and search page:

  • Asked only once
    • mutually exclusive with existing "Popular messages"
    • These messages are potentially easier for new collaborators, and has less impact if reply is not ideal
  • No replies yet
    • mutually exclusive with existing "replied many times")
    • an focus on those that has no any replies. Helpful in editor meetups.
  • Has useful replies
    • mutually exclusive with existing "No useful replies yet")
    • Can let new collaborators take a look at what a helpful reply looks like.
  • Not replied by me
    • mutually exclusive with existing "Replied by me"
    • Don't show the messages that has already replied by the currently logged in users.

Other refactors

  • Move ListArticleFilter object construction into ArticleStatusFilter
    • They all operate on ListArticleFilter and is repeated for article, reply & search article list
    • adds a prop, filterMap to ArticleStatusFilter so that users can adjust options to show / hide
  • convert some components under ListPageControls to Typescript
    • Also types MUI theme to make Typescript happy
  • Adjust tsconfig.json so that Typescript recognizes imports from project root
    • Also include tsconfig in docker build

Screenshots

Deployed to staging: https://dev.cofacts.tw/articles

Article list

image

Reply list

Doesn't have "no replies yet"
image

Search articles

image

Search replies

Not affected
image

@MrOrz MrOrz self-assigned this Mar 16, 2023
@coveralls
Copy link

coveralls commented Mar 16, 2023

Coverage Status

Coverage: 76.19% (-0.04%) from 76.235% when pulling 60138cd on article-filters into 0396606 on master.

@MrOrz MrOrz marked this pull request as ready for review March 17, 2023 20:46
@MrOrz MrOrz merged commit 81e0116 into master Mar 18, 2023
@MrOrz MrOrz deleted the article-filters branch March 18, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants