Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: cloud run auto deploy #549

Merged
merged 9 commits into from
Oct 4, 2023
Merged

ci: cloud run auto deploy #549

merged 9 commits into from
Oct 4, 2023

Conversation

MrOrz
Copy link
Member

@MrOrz MrOrz commented Oct 2, 2023 •
edited
Loading

@coveralls
Copy link

coveralls commented Oct 2, 2023 •
edited
Loading

Coverage Status

coverage: 76.218%. remained the same when pulling 7202a24 on auto-deploy into ceca6be on master.

@MrOrz
fix(workflow): fix GITHUB_TOKEN permission and docker cache
b69199b
@MrOrz
fix(workflows): specify region
c4b947d 
- see if this stops creating new services and starts updating existing ones
@MrOrz MrOrz marked this pull request as ready for review October 2, 2023 19:37
@MrOrz MrOrz self-assigned this Oct 2, 2023
@MrOrz MrOrz requested review from nonumpa and bil4444 October 3, 2023 06:16
@MrOrz MrOrz temporarily deployed to staging October 3, 2023 16:16 — with GitHub Actions Inactive
@MrOrz MrOrz temporarily deployed to staging October 3, 2023 16:16 — with GitHub Actions Inactive
@MrOrz MrOrz temporarily deployed to staging October 3, 2023 16:16 — with GitHub Actions Inactive
@MrOrz MrOrz temporarily deployed to staging-en October 3, 2023 16:42 — with GitHub Actions Inactive
@MrOrz MrOrz temporarily deployed to staging-tw October 3, 2023 16:42 — with GitHub Actions Inactive
@MrOrz MrOrz temporarily deployed to staging-ja October 3, 2023 16:42 — with GitHub Actions Inactive
@MrOrz MrOrz temporarily deployed to staging-tw October 3, 2023 17:35 — with GitHub Actions Inactive
@MrOrz
fix(workflow): env are truthy strings
7202a24 
- Thus we store meaningful strings in env instead of booleans (which will cast to always-true strings)
@MrOrz MrOrz temporarily deployed to staging-tw October 3, 2023 17:47 — with GitHub Actions Inactive
@MrOrz MrOrz temporarily deployed to staging-en October 3, 2023 17:47 — with GitHub Actions Inactive
@MrOrz MrOrz temporarily deployed to staging-ja October 3, 2023 17:47 — with GitHub Actions Inactive
@MrOrz MrOrz merged commit dabc349 into master Oct 4, 2023
10 checks passed
@MrOrz MrOrz deleted the auto-deploy branch October 4, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bil4444 bil4444 bil4444 approved these changes

@nonumpa nonumpa Awaiting requested review from nonumpa

Assignees

@MrOrz MrOrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MrOrz @coveralls @bil4444