-
Notifications
You must be signed in to change notification settings - Fork 177
Add a recipe to count occurrences of a given string within a message #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These three commits can be squashed into one. No need to save the intermediate work in progress with the final merge. git reset master
git add .
git commit -C 83f146e Or you can do an interactive rebase |
I edited with the github online editor. Know how to do this with github? |
You can't squash with GitHub web interface. You need to clone your fork repo, checkout your branch and use PS I personally don't mind merging with multiple commits, but apparently this repo has standards. |
I avoid the GitHub interface except for very small changes. Since the whole concept is to use Git the idea of not using Git is strange and weird to me. As maintainer of my own projects I usually will volunteer to do the squash myself during the merge. So I volunteer to do that here as well But that would mean closing this PR and opening another one. If the rebase were to happen on |
@sukima If @Data-Meister gives you edit access to his fork repo, you'll be able to force-push while staying in this PR. |
|
@lolmaus you ok with a Repo Collaborator merge squash? Means this PR will marked as closed not merged. Also, |
@sukima Yes, if @Data-Meister retains his credit for the commit. |
@lolmaus yes the author does not change only the committer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer this without brackets:
re = new RegExp subStr ,"g"
Closes PR #137 This was a squashed rebase of the following: commit 721deae Author: Data-Meister <fred.fisher.dev@gmail.com> Date: Thu Jan 21 18:02:57 2016 +0000 remove todo commit f56cd11 Author: Data-Meister <fred.fisher.dev@gmail.com> Date: Thu Jan 21 18:02:13 2016 +0000 Fix indentation commit 83f146e Author: Data-Meister <fred.fisher.dev@gmail.com> Date: Thu Jan 21 18:01:17 2016 +0000 Add a recipe to count occurrences of a given string within a message
Closed by commit 9d67a39 |
@lolmaus Darn, missed that comment. I don't want to force push to master because I don't know who has pulled since the merge (2 minutes ago). Perhaps another PR? |
I think it's too minor to bother. @Data-Meister and @sukima, thank you for contributing! |
As discussed here: https://coffeescript-cookbook.github.io/chapters/strings/finding-substrings