Update object-literal.md #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example was wrong. It stated that ?= is similar to JS || when the || will affect not only not defined scenario but also any falsy values (values that evaluate as false) There are way to many differences between the 2: 1. window.var = false; 2. window.var = 0; 3. window.var = ''; 4. window.var = []; 5. window.var = null; window.var ?= 'something' console.log(window.var) -> 1. false 2. 0 3. '' 4. [] 5. 'something' window.var ||= 'something' console.log(window.var) -> 1. 'something' 2. 'something' 3. 'something' 4. [] 5. 'something'
sukima
reviewed
Mar 17, 2017
|
|
||
| {% highlight javascript %} | ||
| window.MY_NAMESPACE = window.MY_NAMESPACE || {}; | ||
| if(window.MY_NAMESPACE == null) { |
There was a problem hiding this comment.
Since type coercion is the crux of the PR maybe this coerced comparison should also be expanded:
if (window.MY_NAMESPACE === null || window.MY_NAMESPACE === undefined) {| {% highlight javascript %} | ||
| window.MY_NAMESPACE = window.MY_NAMESPACE || {}; | ||
| if(window.MY_NAMESPACE == null) { | ||
| window.MY_NAMESPACE = window.MY_NAMESPACE |
There was a problem hiding this comment.
Did you mean window.MY_NAMESPACE = {};?
There was a problem hiding this comment.
Sure, sorry for noticing the typo, I did the changes quickly and that is never a good idea. 👍
sukima
approved these changes
Mar 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example was wrong. It stated that ?= is similar to JS || when the || will affect not only not defined scenario but also any falsy values (values that evaluate as false)
There are way too many differences between the 2:
window.var ?= 'something'
console.log(window.var) ->
window.var ||= 'something'
console.log(window.var) ->