Skip to content

Conversation

tashemi
Copy link
Contributor

@tashemi tashemi commented Jul 30, 2013

No description provided.

@sukima
Copy link
Contributor

sukima commented Aug 1, 2013

I really like this pattern. However, the description / problem as written is confusing. Reading it I had difficulty understanding the need based on the example given. You referenced the idea of a 3-rd party library but in the example you made on yourself with a setCustomSorter() method. That suggested to me that we were not discussing a 3-rd party library / component.

Is it possible to so an example of using a known 3-rd party lib? Or show how to use the Adapter pattern in the cases when you don't have the original source of the 3-rd party lib? How could we make the description a little clearer why this pattern is useful to others?

@tashemi
Copy link
Contributor Author

tashemi commented Aug 1, 2013

@sukima Ok, maybe it is really not clear written and code needs a bit more comments. AwesomeGrid is 3d party library. And the goal is to make friends an existing RandomSorter and AwesomeGrid. But ok, I will take a look for better example.

@sukima
Copy link
Contributor

sukima commented Aug 1, 2013

Ahh! so the example mutates the already loaded 3-rd party library. It makes more sense now.

@tashemi
Copy link
Contributor Author

tashemi commented Aug 2, 2013

@sukima I was sure that comment before the AwesomeGrid declaration is enough to understand what it is

# a fragment of 3-rd party grid component
class AwesomeGrid 

@sukima
Copy link
Contributor

sukima commented Aug 2, 2013

Yeah I missed that. Those are the risk of skimming a document.

@peterhellberg
Copy link
Member

So, should someone merge this? 👍

@tashemi
Copy link
Contributor Author

tashemi commented Aug 7, 2013

if nobody doesn't mind then this pattern can be merged

@peterhellberg
Copy link
Member

Looks good to me.

On Wednesday, August 7, 2013, Tatiana Shemiakina wrote:

if nobody doesn't mind then this pattern can be merged


Reply to this email directly or view it on GitHubhttps://github.com//pull/82#issuecomment-22240929
.

Peter Hellberg
Ruby Developer, Code7 Interactive

fulmicoton added a commit that referenced this pull request Aug 7, 2013
@fulmicoton fulmicoton merged commit bf6de67 into coffeescript-cookbook:master Aug 7, 2013
@fulmicoton
Copy link
Contributor

Merged.

On Wed, Aug 7, 2013 at 12:04 PM, Peter Hellberg notifications@github.comwrote:

Looks good to me.

On Wednesday, August 7, 2013, Tatiana Shemiakina wrote:

if nobody doesn't mind then this pattern can be merged


Reply to this email directly or view it on GitHub<
https://github.com/coffeescript-cookbook/coffeescript-cookbook.github.com/pull/82#issuecomment-22240929>

.

Peter Hellberg
Ruby Developer, Code7 Interactive


Reply to this email directly or view it on GitHubhttps://github.com//pull/82#issuecomment-22241228
.


Masurel Paul
e-mail: paul.masurel@gmail.com

@fulmicoton
Copy link
Contributor

Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants