-
Notifications
You must be signed in to change notification settings - Fork 177
Adapter pattern #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapter pattern #82
Conversation
I really like this pattern. However, the description / problem as written is confusing. Reading it I had difficulty understanding the need based on the example given. You referenced the idea of a 3-rd party library but in the example you made on yourself with a Is it possible to so an example of using a known 3-rd party lib? Or show how to use the Adapter pattern in the cases when you don't have the original source of the 3-rd party lib? How could we make the description a little clearer why this pattern is useful to others? |
@sukima Ok, maybe it is really not clear written and code needs a bit more comments. AwesomeGrid is 3d party library. And the goal is to make friends an existing RandomSorter and AwesomeGrid. But ok, I will take a look for better example. |
Ahh! so the example mutates the already loaded 3-rd party library. It makes more sense now. |
@sukima I was sure that comment before the AwesomeGrid declaration is enough to understand what it is # a fragment of 3-rd party grid component
class AwesomeGrid |
Yeah I missed that. Those are the risk of skimming a document. |
So, should someone merge this? 👍 |
if nobody doesn't mind then this pattern can be merged |
Looks good to me. On Wednesday, August 7, 2013, Tatiana Shemiakina wrote:
Peter Hellberg |
Merged. On Wed, Aug 7, 2013 at 12:04 PM, Peter Hellberg notifications@github.comwrote:
Masurel Paul |
Sorry for the delay. |
No description provided.