feat: 360 image annotation visibility toggle

[haakonflatval-cognite]

Type of change

Jira ticket 📘

https://cognitedata.atlassian.net/browse/REV-875

Description 📝

Toggle to turn on and off annotation visibility.

How has this been tested? 🔍

• Open Reveal examples locally
• Go to https://localhost:3000/?project=3d-test&env=greenfield-3d&modelId=4923307033982497&revisionId=3100284276970593
• Load 360 images helideck-site-2-jpeg
• The lowermost 360 entity has annotations
• Click the toggle in the 360 UI to hide/show annotations
• Make sure annotations are toggled even when not loaded and/or not visible

Test instructions ℹ️

Checklist ☑️

• I am proud of this feature.
• I have performed a self-review of my own code.
• I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
• I have manually tested this for different scenarios (different models, formats, devices, browsers).
• I have commented my code in hard-to-understand areas.
• I have made corresponding changes to the public documentation.
• I have added unit and visuals tests to prove that my feature works to the best of my ability.
• I have refactored the code for readability to the best of my ability.
• I have checked that my changes do not introduce regressions in the public documentation.
• I have outlined any known defects / lacking capabilities in the contents of this PR.
• I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
• I have added TSDoc to any public facing changes.
• I have added "developer documentation" in any package README.md that is related / applicable to this PR.
• I have noted down and am currently tracking any technical debt introduced in this PR.
• I have thoroughly thought about the architecture of this implementation.
• I have asked peers to test this feature.

[codecov]

Codecov Report

Merging #3165 (bd28165) into master (6f52b31) will decrease coverage by 0.08%.
The diff coverage is 37.70%.

@@            Coverage Diff             @@
##           master    #3165      +/-   ##
==========================================
- Coverage   73.36%   73.28%   -0.08%     
==========================================
  Files         333      333              
  Lines       31391    31448      +57     
  Branches     2511     2508       -3     
==========================================
+ Hits        23029    23048      +19     
- Misses       8264     8302      +38     
  Partials       98       98              

Impacted Files	Coverage Δ
viewer/packages/360-images/src/Image360Facade.ts	33.56% <0.00%> (-0.48%)	⬇️
...es/360-images/src/collection/Image360Collection.ts	0.00% <0.00%> (ø)
viewer/packages/360-images/src/types.ts	0.00% <0.00%> (ø)
...es/360-images/src/entity/Image360RevisionEntity.ts	43.93% <38.46%> (-0.21%)	⬇️
...images/src/collection/DefaultImage360Collection.ts	61.21% <54.54%> (-1.43%)	⬇️

... and 1 file with indirect coverage changes

[Savokr]

Looks good! One minor thing I noticed is that annotations are often loaded before the actual 360 image cubemap is created, so this creates a strange effect of floating meshes before you enter a 360 image, I guess we should ensure that 360 image cubemap is added to the scene first and then annotations should be added as well. I think it could be addressed in a separate PR as it is not critical. Video with this behaviour:

Screen.Recording.2023-04-25.at.12.02.59.mov

[haakonflatval-cognite]

Looks good! One minor thing I noticed is that annotations are often loaded before the actual 360 image cubemap is created

Yes, I have seen this. It's tracked in https://cognitedata.atlassian.net/browse/REV-882

[haakonflatval-cognite]

I have started to wonder whether this should just be set using the styling API. collection.setDefaultStyle({ visibility: false }); does the same thing as collection.setImageAnnotationVisibility(false);.

Will wait with merging this, discussing with Christopher when he's back

[haakonflatval-cognite]

I've decided to butcher this in favor of the styling PR :( Oh well, maybe we'll see use for it in the future