Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for node data fetching in React Components #3518

Merged
merged 42 commits into from
Aug 1, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/UX-1136

Description 📝

Implement FDM node data query and expose it.

How has this been tested? 🔍

Test instructions ℹ️

Given a proper FDM setup, you should now be able to register a callback in onNodeClicked that receives the clicked node data.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner July 27, 2023 10:15
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few questions but nothing major. Only thing is that I think we should add an example in the storybook in the same way as I did with styling capabilities. It will allow to easily test this functionality now and later on. So, just expanding Reveal3DResources story should be fine.

react-components/src/components/Reveal3DResources/types.ts Outdated Show resolved Hide resolved
react-components/src/utilities/FdmSDK.ts Outdated Show resolved Hide resolved
react-components/src/utilities/FdmSDK.ts Show resolved Hide resolved
react-components/src/utilities/FdmSDK.ts Outdated Show resolved Hide resolved
@Savokr Savokr added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jul 31, 2023
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prop on Reveal3DResources works good but query feels a little too slow. I think when we will be highlighting clicked objects it will feel quite bad for the user, so we need to think how to speed it up a little bit.

@haakonflatval-cognite haakonflatval-cognite removed the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Aug 1, 2023
Copy link
Contributor

@Savokr Savokr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! We will probably need to do something regarding the time of all requests but can fix it in future PRs.

@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Aug 1, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit bc0d4a7 into master Aug 1, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants