Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add withSuppressRevealEvents HOC #3545

Merged
merged 4 commits into from
Aug 3, 2023
Merged

feat: add withSuppressRevealEvents HOC #3545

merged 4 commits into from
Aug 3, 2023

Conversation

christjt
Copy link
Contributor

@christjt christjt commented Aug 2, 2023

Type of change

Feat

Description 📝

Adds a higher order component which suppresses event propagation to Reveal. Also adds using this HOC to wrap the toolbar.

Test instructions ℹ️

In the toolbar example in storybook, hover over the toolbar and try scrolling the mouse wheel. Before this change, the viewer would zoom, but now event propagation stops.

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@christjt christjt added auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack labels Aug 2, 2023
@christjt christjt requested a review from a team as a code owner August 2, 2023 13:48
pramodcog
pramodcog previously approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@pramodcog pramodcog left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well!, minor comment added 😃

@christjt christjt enabled auto-merge (squash) August 3, 2023 07:23
@christjt christjt merged commit e369670 into master Aug 3, 2023
13 checks passed
@christjt christjt deleted the christjt/prevent-event-hoc branch August 3, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodcog pramodcog pramodcog approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christjt @pramodcog