Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow fetching bounding boxes for multiple node ids #3866

Merged

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented Nov 6, 2023

Type of change

Feat

Jira ticket 📘

Description 📝

Add method for fetching the bounding box enclosing multiple nodes, not just one.

How has this been tested? 🔍

Locally, linked into FDX

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Nov 6, 2023
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner November 6, 2023 13:00
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #3866 (c1c2f96) into master (e5d515a) will increase coverage by 0.01%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3866      +/-   ##
==========================================
+ Coverage   71.45%   71.47%   +0.01%     
==========================================
  Files         351      351              
  Lines       35085    35096      +11     
  Branches     2672     2675       +3     
==========================================
+ Hits        25071    25084      +13     
+ Misses       9906     9904       -2     
  Partials      108      108              
Files Coverage Δ
...packages/cad-model/src/wrappers/CogniteCadModel.ts 79.04% <100.00%> (+0.38%) ⬆️

... and 1 file with indirect coverage changes

@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Nov 6, 2023
@haakonflatval-cognite haakonflatval-cognite changed the title feat: allow fetching bounding box for multiple node ids feat: allow fetching bounding boxes for multiple node ids Nov 6, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit c159ec3 into master Nov 6, 2023
21 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/multiple-instance-bounding-boxes branch November 6, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants