Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-components): add missing exports and change some types #4558

Merged
merged 8 commits into from
May 31, 2024
Merged

chore(react-components): add missing exports and change some types #4558

merged 8 commits into from
May 31, 2024

Conversation

haakonflatval-cognite
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite commented May 31, 2024 •
edited
Loading

Type of change

Chore

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

  • Add missing exports
  • Rename Image360 add option types
  • Allow names from use3DModelNames to be undefined (when input models are undefined)

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner May 31, 2024 08:08
@haakonflatval-cognite haakonflatval-cognite changed the title chore(react-components): add missing exports chore(react-components): add missing exports and change some types May 31, 2024
danpriori
danpriori approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@danpriori danpriori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just some cosmetic suggestions.

@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) May 31, 2024 15:17
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label May 31, 2024
@haakonflatval-cognite haakonflatval-cognite merged commit 2570052 into master May 31, 2024
14 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/missing-exports branch May 31, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danpriori danpriori danpriori approved these changes

Assignees
No one assigned
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haakonflatval-cognite @danpriori