Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Fixes for the architecture #4569

Merged
merged 7 commits into from
Jun 5, 2024
Merged

feat: Fixes for the architecture #4569

merged 7 commits into from
Jun 5, 2024

Conversation

nilscognite
Copy link
Contributor

@nilscognite nilscognite commented Jun 5, 2024 •
edited
Loading

Type of change

Feat

Description 📝

  • Added 2 function in ICustomObject and implemented in CustomObject
  • Refactored in some intersection to use useDepthTest and added a predicate to filter intersections
  • beforeRender is needed to speed up the rendering for the architecture
  • useDepthTest will fix a bug in the architecture
  • All are tested on the architecture and works as intended

@nilscognite nilscognite requested a review from a team as a code owner June 5, 2024 06:38
@nilscognite nilscognite changed the title (feat) Initial commit (feat) Fixes for the architecture Jun 5, 2024
@nilscognite nilscognite changed the title (feat) Fixes for the architecture feat: Fixes for the architecture Jun 5, 2024
haakonflatval-cognite
haakonflatval-cognite requested changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few questions

viewer/packages/api/src/public/migration/Cognite3DViewer.ts Outdated Show resolved Hide resolved
viewer/packages/api/src/public/migration/Cognite3DViewer.ts Outdated Show resolved Hide resolved
viewer/packages/api/src/public/migration/Cognite3DViewer.ts Show resolved Hide resolved
viewer/packages/api/src/public/migration/Cognite3DViewer.ts Outdated Show resolved Hide resolved
haakonflatval-cognite
haakonflatval-cognite approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@haakonflatval-cognite haakonflatval-cognite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nilscognite nilscognite merged commit 36188d0 into master Jun 5, 2024
14 checks passed
@nilscognite nilscognite deleted the no/course branch June 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haakonflatval-cognite haakonflatval-cognite haakonflatval-cognite approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilscognite @haakonflatval-cognite