Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated pkgconfig file not compliant with the standard #62

Closed
GiulioRomualdi opened this issue Jul 30, 2020 · 4 comments
Closed

Generated pkgconfig file not compliant with the standard #62

GiulioRomualdi opened this issue Jul 30, 2020 · 4 comments

Comments

@GiulioRomualdi
Copy link
Contributor

The cppad.pc file generated by the library does not contain the usual structure

prefix=${pcfiledir}/../..
exec_prefix=${prefix}
includedir=${prefix}/include
libdir=${exec_prefix}/lib

However, this creates several problems when I tried to import the library in vcpkg microsoft/vcpkg#12560

Indeed as @Neumann-A suggested in microsoft/vcpkg#12560 (comment) the prefix variable must be defined in every pkg-config file.

FYI @traversaro

@GiulioRomualdi
Copy link
Contributor Author

#63 should fix the issue

@bradbell
Copy link
Contributor

bradbell commented Dec 2, 2020

I have added the requested extra variables to the cppad.pc and cppad-uninstalled.pc files. See the heading Extra Definitions on
https://coin-or.github.io/CppAD/doc/pkgconfig.htm#cppad.pc.Extra%20Definitions

For more information about the change, see the heading 12-02 on
https://coin-or.github.io/CppAD/doc/whats_new_20.htm#12-02

Or for even more, see the commit
cabee29

The cppad.pc file generated by the library does not contain the usual structure

prefix=${pcfiledir}/../..
exec_prefix=${prefix}
includedir=${prefix}/include
libdir=${exec_prefix}/lib

Does this addition to cppad.pc resolve this issue ?

@bradbell
Copy link
Contributor

bradbell commented Jan 3, 2021

@GiulioRomualdi Does this solve the issue for you ? If so, would you please close it.

@bradbell bradbell closed this as completed Jan 3, 2021
@traversaro
Copy link

Thanks @bradbell, I think that solved the issue. The definitive test wil be done when we update the cppad version used in vcpkg, and we try to remove the patches added in microsoft/vcpkg#12560.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants