Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication between colcon-cargo and colcon-ros-cargo #21

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

nnmm
Copy link
Contributor

@nnmm nnmm commented Mar 26, 2022

This tries to make colcon-cargo a better base class for colcon-ros-cargo, so that both packages have fewer combined lines.

As a concrete benefit, colcon-cargo now supports cleaning up the build directory.

I changed the installation location for binaries to be ${prefix}/bin, since I think that's a more standard location.

@nnmm
Copy link
Contributor Author

nnmm commented Mar 26, 2022

I tested that the example from the README still works.

@nnmm
Copy link
Contributor Author

nnmm commented Mar 30, 2022

@esteve There's also this PR. I'm not sure if it makes much sense for non-ROS packages to follow the https://www.ros.org/reps/rep-0122.html install space layout, but if it does, this would be a nice simplification.

@esteve
Copy link
Contributor

esteve commented Apr 1, 2022

@nnmm I have to look more into this, but a priori colcon-cargo must not depend / assume the same conventions as ament_cargo packages. colcon-cargo is meant to be for pure cargo packages, that don't depend on the ament build system or ROS at all.

@nnmm nnmm changed the title Build with cargo-ament-build Reduce duplication between colcon-cargo and colcon-ros-cargo Apr 6, 2022
This tries to make colcon-cargo a better base class for colcon-ros-cargo,
so that both packages have fewer combined lines.

As a concrete benefit, colcon-cargo now supports cleaning up the build directory.
@nnmm
Copy link
Contributor Author

nnmm commented Apr 6, 2022

@esteve I changed this PR to no longer use cargo-ament-build. Now it's just a restructuring between this package and colcon-ros-cargo.

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nnmm great work!

@nnmm
Copy link
Contributor Author

nnmm commented Apr 24, 2022

Thanks! Unfortunately, CI seems to have a hiccup. Do you know what's missing @esteve?

@esteve
Copy link
Contributor

esteve commented Apr 24, 2022

@nnmm I've triggered CI again, but there seems to be a job stuck. I'll look into it later, but it doesn't seem to appear on the Github actions tab, though.

@esteve
Copy link
Contributor

esteve commented Apr 25, 2022

@nnmm I don't know where that job that is stuck comes from, I've submitted #23 which removes the GitHub actions to see if that test is from outside. It looks like it, there are no GitHub actions, but that job persists. I wonder if it's an organization-level webhook.

@esteve
Copy link
Contributor

esteve commented Apr 25, 2022

@nnmm it's really weird, seems to be coming from this old CI configuration:

https://github.com/colcon/colcon-cargo/blob/8d13687c13e88f729ecdf5d3c7f31e78f9513587/.github/workflows/ci.yml#L13-L14=

but I don't understand why it's being triggered now

@esteve
Copy link
Contributor

esteve commented Apr 29, 2022

@nnmm CI seems to be fixed now

@nnmm
Copy link
Contributor Author

nnmm commented Apr 29, 2022

Cool! From renaming to main?

@nnmm nnmm merged commit 0e64a99 into colcon:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants