only unwrap default values in the mixin extension which have been wrapped by it #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
reviewed
Apr 16, 2020
I don't know of any other location where the function is being used. If you know any please point me to them so I can take a look to double check. |
I'm not aware of any. I was thinking that it would be nice to have the original wrap and unwrap functions deal with this scenario so if it arises in other places we don't have to add similar workarounds. But, I don't have an alternative proposal, so this fix lgtm. |
jacobperron
approved these changes
Apr 16, 2020
delete-merged-branch
bot
deleted the
dirk-thomas/fix-handling-default-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21 which is a regression of #19.