Skip to content

Conversation

elpete
Copy link
Contributor

@elpete elpete commented Jul 11, 2016

LogBox newb here, so definitely let me know if this is bad in any way, but I figured since modules act as interceptors, the cbdebugger module could register itself with LogBox. I had to tweak the method calls since getAppendersMap() is a private method. Let me know what you think!

@elpete
Copy link
Contributor Author

elpete commented Jul 12, 2016

After talking with @bdw429s on Slack, I've issued a pull request there to make getAppendersMap public (ColdBox/coldbox-platform#276)

@elpete elpete closed this Jul 12, 2016
@elpete elpete reopened this Jul 12, 2016
Use the (now public) `getAppendersMap` function from LogBox.
@elpete
Copy link
Contributor Author

elpete commented Jul 12, 2016

Changed the pull request to add the interceptor here as suggested in the README

@elpete
Copy link
Contributor Author

elpete commented Jul 12, 2016

The build should pass when ColdBox/coldbox-platform#276 is accepted.

@lmajano lmajano merged commit 43bbbb4 into coldbox-modules:development Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants