Fix: Ensure non-configured rules default to empty array #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a developer declines to set a value for `moduleSettings.cbSecurity.rules`, they get an error: ``` Element SETTINGS.RULES is undefined in ARGUMENTS. ``` IMHO, this is a failure on Coldbox's part to properly merge the dev-defined coldbox `moduleSettings.cbSecurity` struct with cbSecurity's own `settings` struct. Regardless, I'd expect the `rules` array to default to an empty array _[as documented](https://coldbox-security.ortusbooks.com/getting-started/first-chapter)_.
|
We can probably decline this PR. The only circumstance in which this "bug" occurs is when a dumb developer (cough, sortof me, sortof) tries to manually run the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a developer declines to set a value for
moduleSettings.cbSecurity.ruleswhen configuring cbSecurity, they get an error:IMHO, this is a failure on Coldbox's part to properly merge the
dev-defined coldbox
moduleSettings.cbSecuritystruct with cbSecurity'sown
settingsstruct. Regardless, I'd expect therulesarray todefault to an empty array as documented.