Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced accessibility #24

Open
ffoodd opened this issue May 28, 2021 · 0 comments
Open

Enhanced accessibility #24

ffoodd opened this issue May 28, 2021 · 0 comments
Assignees
@coliff
Labels
enhancement New feature or request

Comments

@ffoodd
Copy link

ffoodd commented May 28, 2021

As stated in Nicolas Steenhout's post regarding hide/how password feature, a little change could improve accessibility quite a lot: add aria-pressed attribute, being true | false — no need for the switch role, see Toggle Button's example on Inclusive Component by Heydon Pickering.

Thanks for such feature, it's really handy :)
@coliff coliff added the enhancement New feature or request label May 29, 2021
slackero added a commit to slackero/bootstrap-show-password-toggle that referenced this issue Oct 30, 2021
@slackero
Added aria-pressed attribute to button
dd9cb61 
Solves issue coliff#24
@coliff coliff self-assigned this May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coliff coliff

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@coliff @ffoodd