Skip to content

check for pipToggle existence #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2019
Merged

check for pipToggle existence #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ videojs-record changelog
- Trigger `Event.RETRY` for image-only (by @vendramini)
- Add `style` and `sass` entries to `package.json`
- Specify non-minified videojs-record in `main` entry of `package.json`
- Check for `pipToggle` (#411)
- Bump required version for videojs-wavesurfer to 2.11.0 or newer


Expand Down
3 changes: 2 additions & 1 deletion src/js/videojs.record.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,8 @@ class Record extends Plugin {
this.player.controlBar.el().insertBefore(
this.player.recordToggle.el(),
this.player.controlBar.el().firstChild);
if (this.player.controlBar.pictureInPictureToggle === undefined) {
if (this.player.controlBar.pictureInPictureToggle === undefined &&
this.player.pipToggle !== undefined) {
// add custom PiP toggle
this.player.controlBar.addChild(this.player.pipToggle);
} else {
Expand Down