Issue cleanup

[jacadzaca]

Hey there. Going through the repository's issues can be quite cumbersome due to some of them not being 'real' issues, being already solved etc. To help with that, I put together a list of issues I think could be closed (reading the comments reveals that etc.)

I'd also like to propose adding 2 new tags: good first issue and help wanted, so new contributors have easier time finding issues they'd like to work on. We could also list the project on GoodFirstIssue or the likes.

The list:

Solved (or seemingly solved)

• Exception when there's no ':' when parsing value #348
• UTC timezone identification is broken #335
• bug: icalendar does wrong date comparison #332
• :bug There is no'\,' in the original text, but'\,' appears in the exported ics file #326
• Proposing a PR to fix a few small typos #323
• vCategory.__init__ breaks if a non-iterable is passed (Typo) #300
• RRULE with UNTIL not working since version 3.9.2? #298
• ATTACH not working for vUri #295
• TZID emissions don't match timezone names, but may later result in a timezone name lookup #291
• Attachment parsing #290 (see ATTACH not working for vUri #295?)
• Docs site is down?  #288 (site's up)
• tox.ini extras declared in wrong way #285 (no more extras in tox.ini)
• VALARM in Events #276
• Looking for a simple way to parse a list of events  #275 (calendar.walk exists)
• Document Page Still Broken #270 (see Docs site is down?  #288)
• icalendar Web site lost format #264 (see Document Page Still Broken #270)
• Categories should be comma separated not repeated #263
• ValueError: need more than 1 value to unpack #254
• Double newline lineendings #166 (not a bug)
• Idea: Use codecov instead of pasted coverage output #135 (we use codecov)
• BYDAY should also receive weekdaylist #126
• Hint for exporting to Google Calendar #121 ("""solved""")
• Content line could not be parsed into parts Exception #104
• failing to parse a VEVENT with embedded HTML #84

Out of scope of the project

• how to automatically create event on google calendar #341
• how convert an ics to md, if (many) vevents don't have category #317
• How to match dateuilts.rrule and python icalendar daylightsavingtime aware #162
• converting icalendar into JSON -- a working example #85 (not really an issues?)

Issues that should be given the:

good first issue tag

• Ignore X-... properties also at end of file? #350
• Multiple METHOD: definitions in the calendar ->ValueError: A VCALENDAR must have at most one METHOD #286
• Add support for BYWEEKDAY #268

help wanted tags

• Parsing ics data failed:Content line could not be parsed into parts: 'REFRESH - INTERVAL; VALUE = DURATION:PT48H': REFRESH - INTERVAL #351
• Ignore X-... properties also at end of file? #350
• Adding an EXDATE with type date does not set the element's VALUE as DATE #349
• Multiple METHOD: definitions in the calendar ->ValueError: A VCALENDAR must have at most one METHOD #286
• Add support for BYWEEKDAY #268
• Attendee without email address. #266 and Add example: invalid:nomail in ATTENDEE #130
• Cannot decode 'TRIGGER' item #215
• Alarm Trigger field from Apple OSX iCal breaks with Value Error #69

[geier]

Thank you for the effort!

I agree with all of your suggestions.

New labels are created and attached.

[geier]

@niccokunzmann I'd also be in favor of closing solved issues that @jacadzaca has identified. Perhaps we can move the out of scopes one to dicsussions?

[niccokunzmann]

Perhaps we can move the out of scopes one to discussions?

That sounds good... Personally, to keep the discussion count low, I would say it can be closed and suggest that is can be recreated as a discussion.

Thanks for creating this issue. I have identified that this is out of scope for this module but still other people might be interested to talk about it and so I suggest that you create a discussion about this here: https://github.com/collective/icalendar/discussions. I will close this issue now and please link the new discussion you create as a comment, so people can have a look!

[niccokunzmann]

@geier I added @jacadzaca with write access. This can speed up development and take a load from our shoulders.
@jacadzaca You have write access now. There seems to be no disagreement with the changes you proposed and you can go ahead and do something about them. Please get back to us if you have any questions. You can merge and review pull requests but please do not merge your own pull requests. Happy Hacking!

[jacadzaca]

I closed most of the issues I've listed, except for two. #348 might require a better fix than the one proposed and #298 is a bug, which I have no idea how to fix. I assigned @geier to help with #348 and #298 is labeled help wanted

[jacadzaca]

also, #162 should be closed when we remove pytz.

[jacadzaca]

GoodFirstIssue pull request - DeepSourceCorp/good-first-issue#461