Remove manual LDAP search pagination on UGM principal search call…
#53
Conversation
…s. This is done in downstream API as of ``node.ext.ldap`` 1.0b7.
TODO.rst
Outdated
| [ ] - group in group (depends on: node.ext.ldap: group.groups support) | ||
| [ ] - roles from ldap | ||
| [ ] - Option on LDAP inspector whether to use query filters from users and | ||
| groups config |
There was a problem hiding this comment.
This is MarkDown syntax, which PyPI does not support. In this case, for the last line it gives '(ERROR/3) Unexpected indentation.' Also, for MarkDown it should be the other way around: - [ ].
You can use restview TODO.rst to check the ReStructuredText parsing of this file. Or restview --long-description to check the long description from setup.py that would end up on PyPI.
See https://pypi.org/project/restview/
There was a problem hiding this comment.
The longdescription command from zest.releaser works too, and is easier to type, but I prefer restview these days.
There was a problem hiding this comment.
I just finish the work on node.ext.ldap 1.0b7, will fix with the next commit defining the node.ext.ldap dependency version
| @@ -8,7 +8,8 @@ Setup | |||
| Basics | |||
| ------ | |||
|
|
|||
| :: | |||
| .. code-block:: pycon | |||
There was a problem hiding this comment.
Shouldn't pycon be python? Hm, it works though when I try it with restview, and when I use a random string instead it gives an error. So pycon is apparently okay.
I see very minor differences. Is pycon maybe meant as variant that shows better in presentations, for example on the PyCon conference? Do you know that? Just curious. :-)
There was a problem hiding this comment.
pycon is python console
There was a problem hiding this comment.
Ah! Thanks for the info.
|
node.ext.ldap 1.0b7 is released. @mauritsvanrees from my POV we can merge and release. |
…s. This is done in downstream API as of
node.ext.ldap1.0b7.Relates to conestack/node.ext.ldap#36
@jensens @pbauer @fredvd @mauritsvanrees May you be so kind to check the changes?