Deserialize BigDecimal correctly from YAML using Psych

[jarmo]

Fixes #588.

[coveralls]

Coverage increased (+0.05%) when pulling 5f1c475 on jarmo:master into 02c7032 on collectiveidea:master.

[coveralls]

Coverage increased (+0.05%) when pulling ed14ca6 on jarmo:master into 02c7032 on collectiveidea:master.

[jarmo]

For some reason it fails for Ruby 1.9.2 - maybe that version of Ruby does not have the code for deserializing BigDecimal. I don't have any 1.9.2 lying aroud to check that.

[coveralls]

Coverage increased (+0.07%) when pulling e8db786 on jarmo:master into 02c7032 on collectiveidea:master.

[ledermann]

+1 for merge

[jarmo]

Still not merged? Sigh.

[brupm]

👍

[albus522]

This has several unrelated changes and don't use define_method. Use alias_method like the rest of the project.

[jarmo]

@albus522 What unrelated changes do you have in mind? If you mean the changes related with Windows platform then i don't see them as unrelated changes per se, because they were needed for me to make that patch since i'm developing on that platform.

Also, define_method in this case is more correct/clean opposed to alias_method since it does not pollute the namespace with unneeded methods. And if you say that alias_method is used for other similar problem solutions then that does not mean it is best solution. alias_method should be used for aliasing methods and not for "overrides".

[albus522]

They are unrelated to deserializing BigDecimal and again please use alias_method

[noelrappin]

Okay, what's stopping this one from being merged?

[albus522]

Did you read the comments?

[scpike]

@albus522 I'm wondering if it's possible to remove this hack entirely, now that delayed_job targets ruby 1.9.3+ (correct me if I'm wrong on that, I'm going off what's tested in travis). How familiar are you with the history of this piece of the code?

@bryckbost added this code back in 2012 (14cfa87). All the tests are still passing if I just remove what was done in 2012: https://github.com/scpike/delayed_job/compare/collectiveidea:master...remove-psych-extensions?expand=1

[albus522]

I like deleting code.

[scpike]

@albus522 I appreciate your commitment to code quality :). I'm going to create a PR with the removal, and would appreciate suggestions on any additional tests you'd like to see added before you're comfortable merging it.

[jarmo]

+1 for deletion now that Ruby 1.8 and 1.9.2 are totally out of date.

[albus522]

#679 should take care of this