Separate yaml #710
Merged
Separate yaml #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DelayedJob` makes freedom patches of `Psych`'s `resolve_class` method. It misses to guard this method from empty class names. `Psych` does it: https://github.com/tenderlove/psych/blob/2c644e18/lib/psych/class_loader.rb#L25 While deserializing an anonymous struct the class name is an empty string (`""`). Constantizing an empty string resolves to `Object`. This leads to this error: #<NoMethodError: undefined method `members' for #<Object:0xXXXXXXX>> After this commit deserializing anonymous structs works again.
|
This also includes #475 |
albus522
force-pushed
the
separate-yaml
branch
from
ebf6789
to
e530194
Compare
Conflicts: lib/delayed/psych_ext.rb
It doesn't do this on its own
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.