Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat does not scroll down automatically on Catalina #3691

Closed
dmd opened this issue Oct 10, 2019 · 22 comments
Closed

Chat does not scroll down automatically on Catalina #3691

dmd opened this issue Oct 10, 2019 · 22 comments

Comments

@dmd
Copy link

dmd commented Oct 10, 2019

On MacOS Catalina, when new lines appear at the bottom of the window, the window does not scroll down to see them.

@akempgen
Copy link
Contributor

akempgen commented Oct 13, 2019

I believe this is because DOMElement.scrollTop always returns 0 on Catalina, breaking some of the scrolling calculations. I reported it as a WebKit regression to Apple, but will also check if we can implement it differently.

@smfr
Copy link

smfr commented Oct 16, 2019

Which DOMElement is Colloquy setting it on? You should be using document.scrollingElement now (see webkit.org/b/189472).

@akempgen
Copy link
Contributor

I’m currently away from my laptop for a few days, so I can’t test this, but it looks like we are using the document.body element on Mac (

- (void) scrollToBottom {
) and iOS (
function scrollToBottom(animated, suppressEnforceScrollbackLimit) {
).
I’m not too familiar with working with the DOM, is there a deprecation or release notes regarding this change that I missed?
Besides using document.scrollingElement (or perhaps NSResponder’s scrollToEndOfDocument:) in future versions, is there anything we can do to fix the behavior for existing versions?

@smfr
Copy link

smfr commented Oct 16, 2019

document.scrollingElement was added in 2015, so if that's enough compatibility you can just always use it. Otherwise just check for it:
var elementToTScroll = 'scrollingElement' in document ? document.scrollingElement : document.body
or something.

@T8191
Copy link

T8191 commented Oct 20, 2019

Blame Catalina if you must, but I only installed that yesterday (19 Oct) and my Colloquy issue started weeks ago ... on both Mac and iPad.
BTW, I am a totally non-tech Senior Citizen, just a 40-year desktop user.

@gkellogg
Copy link

Issue for me definitely started right after upgrading to Catalina. Along with some other migration issues, it was enough for me to spend a day rolling back to Mojave. When this and other text rending issues are cleared up, I'll try Catalina again.

@nickhilliard
Copy link

this is still an issue on the 2019-10-22 update of macos 10.15.

@hyperknot
Copy link

Just to conclude, this is fixed by using the new build from http://alex.speanet.info/stuff/Colloquy_7048_with_Bouncer_103.zip

@HFComm
Copy link

HFComm commented Nov 17, 2019

Will there be an "official" publish to the Colloquy site?

Or if not, can someone list the steps to compile this myself? (I'm a complete non-programmer but a sysadmin who speaks the language, so you'd need to be painfully specific with the steps... )

@akempgen
Copy link
Contributor

That build is made by me, and it's the same binary that we would upload to the main site if we decide that this is the version we want to release.

To make your own build, read https://github.com/colloquy/colloquy/blob/main/README.md for the checkout + dependencies. For a release, I use the https://github.com/colloquy/colloquy/blob/main/Tools/release-mac-old.sh script, but I'm not sure how well it works if you don't have the sources for the bouncer plugin.

@HFComm
Copy link

HFComm commented Nov 23, 2019

Thanks. Unfortunately building it myself went about as well as I expected. I'll just keep my eye on the official site (have to for regulatory reasons... can only use downloads from "official" sites).

@zadr zadr closed this as completed Nov 23, 2019
akempgen added a commit that referenced this issue Nov 24, 2019
@ProfessorTom
Copy link

I too would love to get the macOS binary/upgrade that is compatible with Catalina.

Alas, I see the commit message only mentions iOS 13.

Does this fix also apply to the macOS version? When will that version be released? Finally, how can I install that version? (The http://colloquy.app link doesn't work and checking for updates in version 2.4.3 does not find any update.)

Screen Shot 2019-12-15 at 5 02 59 PM

@smellup
Copy link

smellup commented Dec 23, 2019

Hi,

Where I can get a Colloquy build with the fix please.
The latest version is still 2.4.3 which is is bugged.

Thank you by advance.
Eric

@AndrewRayCode
Copy link

Was a new version not released? I have this issue and Colloquy is telling me I'm up to date

@akempgen
Copy link
Contributor

No, we don't have a release yet, but as mentioned in a comment above, the build at http://alex.speanet.info/stuff/Colloquy_7048_with_Bouncer_103.zip contains the fix.

@T8191
Copy link

T8191 commented Mar 16, 2020 via email

@andydude
Copy link

When is this going to get fixed? I just upgraded to Catalina, and scrolling stopped working.

@nyshawn
Copy link

nyshawn commented Jun 17, 2020

No, we don't have a release yet, but as mentioned in a comment above, the build at http://alex.speanet.info/stuff/Colloquy_7048_with_Bouncer_103.zip contains the fix.

File Not Found

...in your link, akempgen. Can you possibly repost that?

@akempgen
Copy link
Contributor

a slightly newer build is now in a slightly better location: https://github.com/colloquy/colloquy/releases/tag/mac%2F2020%2F2.5-prerelease-7051

@sjWiz
Copy link

sjWiz commented Jul 2, 2020

Akempgen, thank you so much for recoding it! The older link no longer works; thanks for providing the new link :)

Do i need to remove the pre-existing colloq install or can I install on top of it?

@akempgen
Copy link
Contributor

akempgen commented Jul 2, 2020

you can just install it on top. you probably will be asked a few times for you keychain pw at launch (once per connection), but that should be it

@sjWiz
Copy link

sjWiz commented Jul 3, 2020

I don't think i'm using keychain with it. Should I be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests