-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chat does not scroll down automatically on Catalina #3691
Comments
I believe this is because DOMElement.scrollTop always returns 0 on Catalina, breaking some of the scrolling calculations. I reported it as a WebKit regression to Apple, but will also check if we can implement it differently. |
Which DOMElement is Colloquy setting it on? You should be using document.scrollingElement now (see webkit.org/b/189472). |
I’m currently away from my laptop for a few days, so I can’t test this, but it looks like we are using the document.body element on Mac ( colloquy/Mac-Old/Mac-Old/Views/JVStyleView.m Line 667 in 69d4747
colloquy/Mobile/Resources/transcript.js Line 228 in 69d4747
I’m not too familiar with working with the DOM, is there a deprecation or release notes regarding this change that I missed? Besides using document.scrollingElement (or perhaps NSResponder’s scrollToEndOfDocument:) in future versions, is there anything we can do to fix the behavior for existing versions? |
document.scrollingElement was added in 2015, so if that's enough compatibility you can just always use it. Otherwise just check for it: |
Blame Catalina if you must, but I only installed that yesterday (19 Oct) and my Colloquy issue started weeks ago ... on both Mac and iPad. |
Issue for me definitely started right after upgrading to Catalina. Along with some other migration issues, it was enough for me to spend a day rolling back to Mojave. When this and other text rending issues are cleared up, I'll try Catalina again. |
this is still an issue on the 2019-10-22 update of macos 10.15. |
Just to conclude, this is fixed by using the new build from http://alex.speanet.info/stuff/Colloquy_7048_with_Bouncer_103.zip |
Will there be an "official" publish to the Colloquy site? Or if not, can someone list the steps to compile this myself? (I'm a complete non-programmer but a sysadmin who speaks the language, so you'd need to be painfully specific with the steps... ) |
That build is made by me, and it's the same binary that we would upload to the main site if we decide that this is the version we want to release. To make your own build, read https://github.com/colloquy/colloquy/blob/main/README.md for the checkout + dependencies. For a release, I use the https://github.com/colloquy/colloquy/blob/main/Tools/release-mac-old.sh script, but I'm not sure how well it works if you don't have the sources for the bouncer plugin. |
Thanks. Unfortunately building it myself went about as well as I expected. I'll just keep my eye on the official site (have to for regulatory reasons... can only use downloads from "official" sites). |
I too would love to get the macOS binary/upgrade that is compatible with Catalina. Alas, I see the commit message only mentions iOS 13. Does this fix also apply to the macOS version? When will that version be released? Finally, how can I install that version? (The http://colloquy.app link doesn't work and checking for updates in version 2.4.3 does not find any update.) |
Hi, Where I can get a Colloquy build with the fix please. Thank you by advance. |
Was a new version not released? I have this issue and Colloquy is telling me I'm up to date |
No, we don't have a release yet, but as mentioned in a comment above, the build at http://alex.speanet.info/stuff/Colloquy_7048_with_Bouncer_103.zip contains the fix. |
Fair enough. I have joined my friends on another platform (Keybase) , which actually works much better.
Best wishes, and unsubscribing to emails,
Piers Gardiner
…___________________________________
If you are not the intended addressee, please inform the sender and delete this message from your computer.
On 16 Mar 2020, at 19:34, Alexander Kempgen ***@***.***> wrote:
No, we don't have a release yet, but as mentioned in a comment above, the build at http://alex.speanet.info/stuff/Colloquy_7048_with_Bouncer_103.zip <http://alex.speanet.info/stuff/Colloquy_7048_with_Bouncer_103.zip> contains the fix.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#3691 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANRH2E6IE2QAS4APD5OOX4LRHZ5LXANCNFSM4I7GESVQ>.
|
When is this going to get fixed? I just upgraded to Catalina, and scrolling stopped working. |
File Not Found ...in your link, akempgen. Can you possibly repost that? |
a slightly newer build is now in a slightly better location: https://github.com/colloquy/colloquy/releases/tag/mac%2F2020%2F2.5-prerelease-7051 |
Akempgen, thank you so much for recoding it! The older link no longer works; thanks for providing the new link :) Do i need to remove the pre-existing colloq install or can I install on top of it? |
you can just install it on top. you probably will be asked a few times for you keychain pw at launch (once per connection), but that should be it |
I don't think i'm using keychain with it. Should I be? |
On MacOS Catalina, when new lines appear at the bottom of the window, the window does not scroll down to see them.
The text was updated successfully, but these errors were encountered: