Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable logging in incremental mapping #140

Closed
abhinaythurlapati opened this issue May 20, 2023 · 2 comments · Fixed by #176
Closed

Option to disable logging in incremental mapping #140

abhinaythurlapati opened this issue May 20, 2023 · 2 comments · Fixed by #176

Comments

@abhinaythurlapati
Copy link

abhinaythurlapati commented May 20, 2023 •
edited
Loading

pycolmap.incremental_mapping() produces lot of console output.
suppressing output in jupyter notebook either through contextlib or %%capture is not working.

Any suggestions?
@Phil26AT
Copy link
Collaborator

Phil26AT commented May 26, 2023 •
edited
Loading

I agree that there should be an option to hide the console output. hloc has a wrapper that suppresses the output, this should also work in a jupyter notebook.

@sarlinpe
Copy link
Collaborator

PR #176 adds an option to increase the min log level. This can thus suppress all INFO log messages (once COLMAP has entirely switched to glog in colmap/colmap#2172).

@sarlinpe sarlinpe linked a pull request Sep 19, 2023 that will close this issue
Migrate to glog logging #176
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to glog logging colmap/pycolmap
3 participants
@abhinaythurlapati @sarlinpe @Phil26AT