fix: emulator support for Connection::listSessions #88
+12
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taka-oyama
requested review from
dkkoma,
kt81,
zeriyoshi,
halnique,
ojikeii and
t-matsuno-777
taka-oyama
force-pushed
the
fix/emulator-support-for-list-sessions
branch
from
653b621 to
b7c128e
Compare
halnique
approved these changes
Apr 14, 2023
|
I apologize, I overlooked this earlier. It seems like it would be better to enable the following as well. public function test_no_args(): void
{
if (getenv('SPANNER_EMULATOR_HOST')) {
$this->markTestSkipped('Cannot list sessions on emulator');
}Shall we address this together with #89 ? |
|
I have added the fix for it in #89. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.