110. Balanced Binary Tree #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[110. Balanced Binary Tree](https://leetcode.com/problems/balanced-binary-tree/description/)
nodchip
reviewed
Apr 14, 2024
| return abs(right_height - left_height) <= 1 && isBalanced(root->left) && isBalanced(root->right); | ||
| } | ||
|
|
||
| int recursive_max_height(TreeNode* root, int current_height) { |
There was a problem hiding this comment.
current_height を渡さず、 root == nullptr のときに return 0 し、 recursive_max_height() の呼び出し時の戻り値に + 1 したほが、シンプルになると思います。
There was a problem hiding this comment.
C++ では、関数名は upper camel で書くことが多いと思います。詳しくは、 Google C++ Style Guide 等をご覧ください。
Google C++ スタイルガイド(日本語全訳) Google C++ Style Guide (Japanese) https://ttsuki.github.io/styleguide/cppguide.ja.html
また、関数名は動詞で始め、関数の処理内容を必要最小限の英単語・英語句で表現することが多いと思います。今回の場合は、 GetHeight() あたりで十分だと思います。
There was a problem hiding this comment.
コメントありがとうございます。
leetcode側の関数命名規則に合わせていましたが、自作関数を追加する際はGoogle C++スタイルガイドに準拠します
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
110. Balanced Binary Tree