21. Merge Two Sorted Lists #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodchip
reviewed
Mar 14, 2024
| if(list1 == nullptr)return list2; | ||
| if(list2 == nullptr)return list1; | ||
|
|
||
| ListNode *ret; |
There was a problem hiding this comment.
ret は、変数に含まれる値がどのような役割を持つかを表していないように思います。 root または merged のほうが、より役割を表しているように思います。
There was a problem hiding this comment.
慣習的にretを使ってしまっていましたが、役割を考慮した名前付けにします。
| if(list2 == nullptr)return list1; | ||
|
|
||
| ListNode *ret; | ||
| if(list1->val < list2->val){ |
There was a problem hiding this comment.
while ループの中の if(list1->val < list2->val){ と、処理が重複しているのが気になりました。 while ループの中の処理に統一することはできませんでしょうか？
| if(list2 == nullptr)return list1; | ||
|
|
||
| ListNode *ret; | ||
| if(list1->val < list2->val){ |
There was a problem hiding this comment.
if と (、) と { のあいだに、それぞれスペースを 1 つ空けたほうが良いと思います。
Google C++ Style Guide 等を参考にされることをお勧めいたします。
https://google.github.io/styleguide/cppguide.html#Formatting_Looping_Branching
| class Solution { | ||
| public: | ||
| ListNode* mergeTwoLists(ListNode* list1, ListNode* list2) { | ||
| ListNode ret = ListNode(); |
There was a problem hiding this comment.
ret の代わりに、番兵を表す sentinel を使ってはいかがでしょうか？
| while(list1 != nullptr && list2 != nullptr){ | ||
| // always list1 <= list2 | ||
| if(list1->val > list2->val){ | ||
| swap(list1, list2); |
There was a problem hiding this comment.
これは、引数を別変数に代入して修正するようにします。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/merge-two-sorted-lists/description/