Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish mill-scala-compiler-bridge for Scala 2.13.12 #2798

Closed
lolgab opened this issue Sep 29, 2023 · 4 comments · Fixed by #2830
Closed

Publish mill-scala-compiler-bridge for Scala 2.13.12 #2798

lolgab opened this issue Sep 29, 2023 · 4 comments · Fixed by #2830
Milestone

Comments

@lolgab
Copy link
Member

lolgab commented Sep 29, 2023

No description provided.

@lihaoyi
Copy link
Member

lihaoyi commented Sep 30, 2023

If I'm not mistaken, 2.13.12 publishes their own compiler bridge (scala/scala#10472, https://search.maven.org/artifact/org.scala-lang/scala2-sbt-bridge/2.13.12/jar), so we may be able to just reference theirs rather than continuing to publish our own

@lefou
Copy link
Member

lefou commented Sep 30, 2023

That mean, we need some new logic depending on the Scala version, right?

@lihaoyi
Copy link
Member

lihaoyi commented Oct 1, 2023

Yes it should involve changing the code a bit

@lolgab
Copy link
Member Author

lolgab commented Oct 4, 2023

I think that until we integrate with the current official published bridge, it's best to simply publish our mill-scala-compiler-bridge 0.0.1 for Scala 2.13.12 (not sure it's possible for just a Scala version) so Mill users can have the best experience as soon as possible.

@lolgab lolgab closed this as completed Oct 8, 2023
@lefou lefou added this to the 0.11.6 milestone Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants