Replace Win32 named pipe with simple ServerSocket #1089
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently works fine, but spawns a new server on every invocation!?
I'm not sure if this is a problem introduced by this change but I doubt it.
Maybe I just don't understand the locks code in Mill well enough.. 😄
Anyways, it runs a simple
ServerSocket
on a random port on localhost, and writes that port in a file.Client can then read the port and connect to the server.
I also "tested" the security part of server, by running an Android app that scans the ports of my computer.
It doesn't show the allocated port, so should be good.