ScalaJSModule: Deprecate fastOpt and fullOpt
#2324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no idea why this simple change is failing the build. Do you have an idea, @lolgab ? |
|
Not sure, I'm going to try to run those tests locally later. |
@lolgab Did you have any success? I've seen the same issue in PR #2339 and tried locally to bisect it, but all older tags (0.10.11..0.10.5) failed, so it is probably related to some untracked dependencies. As it only affects ScalaJS tests, my suspicion is a changed node.js version or something in the node.js ecosystem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.