Handle potential null-stream in buildinfo plugin #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Scala implementation just does not load the expected values from the resource file, when the resource file can not be found on the classpath. The Java implementation already throws a
RuntimeException(of anIOException) in this case. The Scala implementation does not.I think missing a generated resource file at runtime is most likely an runtime issue and we should also throw such exception in the Scala implementation to exit early, before a missing value can cause greater harm later. Hence, we now also throw a
RuntimeExceptionwhen the resource file/stream could not be found in the Scala implementation.Fix #2831