Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestModule: Support generation of JUnit-compatible xml report #3099

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

atty303
Copy link
Contributor

@atty303 atty303 commented Mar 22, 2024

fixes #2700

image

I am verifying with MUnit.

@romain-gilles-ultra
Copy link
Contributor

romain-gilles-ultra commented Apr 2, 2024

Hi,
Thanks for this great PR I'm looking forward to it :)
I have a question: do you know how we will distinguish the test suite when we have cross-build?

@atty303
Copy link
Contributor Author

atty303 commented Apr 13, 2024

I have a question: do you know how we will distinguish the test suite when we have cross-build?

Sorry, I don't know, I have not done a cross build. I may investigate if I have time.

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@lefou lefou changed the title feat: added JUnit-compatible xml generation TestModule: Support generation of JUnit-compatible xml report Apr 23, 2024
@lefou lefou merged commit 471238a into com-lihaoyi:main Apr 23, 2024
38 checks passed
@lefou lefou added this to the 0.11.8 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants