Add error log when passing args to run on ScalaJSModule
#3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolgab
changed the title
ScalaJSModule run
lefou
reviewed
Jul 31, 2024
| case c: JsEnvConfig.ExoegoJsDomNodeJs => c.copy(args = args().value.toList) | ||
| case c: JsEnvConfig.JsDom => c.copy(args = args().value.toList) | ||
| case c: JsEnvConfig.Phantom => c.copy(args = args().value.toList) | ||
| case c => c |
There was a problem hiding this comment.
We should use T.log to let the user know in case we match some unknown type and args is non-empty.
lolgab
force-pushed
the
pass-command-line-args-scalajs
branch
from
e741afe
to
67c9abf
Compare
lolgab
changed the title
ScalaJSModule runrun on ScalaJSModule
lolgab
force-pushed
the
pass-command-line-args-scalajs
branch
from
67c9abf
to
7532251
Compare
lefou
approved these changes
Aug 1, 2024
lolgab
changed the title
run on ScalaJSModulerun on ScalaJSModule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3324
Pull Request: #3327