Adding support for java.util.Date #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marcvk can you run the autoformatter to get |
…matAll __.sources + "scalasql[2.13.12].test" + generateTutorial + generateReference to fix formatting (a.o.)
|
@lihaoyi I found that statement in the developer reference doc, is that what you meant? |
|
Should be! Lets run CI again and see if it worked |
|
@marcvk tagged 0.1.7 if youd like to begin using it |
|
thnx! |
counter2015
reviewed
Aug 26, 2024
| @@ -9219,6 +9243,7 @@ val value = DataTypes[Sc]( | |||
| myLocalDate = LocalDate.parse("2023-12-20"), | |||
| myLocalTime = LocalTime.parse("10:15:30"), | |||
| myLocalDateTime = LocalDateTime.parse("2011-12-03T10:15:30"), | |||
| myUtilDate = new SimpleDateFormat("yyyy-MM-dd'T'HH:mm:ss.SSS").parse("2011-12-03T10:15:30.000"), | |||
There was a problem hiding this comment.
Should we use SimpleDateFormat here ?
There are instances where java.text.SimpleDateFormat is used to parse dates. A better approach is to use java.time.format.DateTimeFormatter from the modern Java Time API (java.time) introduced in Java 8, which is thread-safe, more flexible, and offers better support for various date/time formats.
We could also convert from LocalDateTime
import java.time.format.DateTimeFormatter
import java.time.{LocalDateTime, ZoneId, ZoneOffset, ZonedDateTime}
import java.util.Date
val formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss")
val date = Date.from(
LocalDateTime.parse("2023-11-12 03:22:41", formatter)
.toInstant(
ZonedDateTime.now(ZoneId.systemDefault()).getOffset
)
)
println(date)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added support java.util.Date. I've added the same tests as for LocalDateTime and all tests pass successfully. Let me know if anything else is needed.